manishkr commented on code in PR #19229:
URL: https://github.com/apache/datafusion/pull/19229#discussion_r2602540768
##########
datafusion/spark/src/function/datetime/date_add.rs:
##########
@@ -136,3 +145,48 @@ fn spark_date_add(args: &[ArrayRef]) -> Result<ArrayRef> {
};
Ok(Arc::new(result))
}
+
+#[cfg(test)]
+mod tests {
+ use super::*;
+ use arrow::datatypes::Field;
+
+ #[test]
+ fn test_date_add_non_nullable_inputs() {
+ let func = SparkDateAdd::new();
+ let args = &[
+ Arc::new(Field::new("arg_int8", DataType::Int8, false)),
+ Arc::new(Field::new("arg_int16", DataType::Int16, false)),
+ ];
+
+ let ret_field = func
+ .return_field_from_args(ReturnFieldArgs {
+ arg_fields: args,
+ scalar_arguments: &[None, None],
+ })
+ .unwrap();
+
+ assert_eq!(ret_field.data_type(), &DataType::Date32);
+ assert!(!ret_field.is_nullable());
+ }
+
+ #[test]
+ fn test_date_add_nullable_inputs() {
+ let func = SparkDateAdd::new();
+ let args = &[
+ Arc::new(Field::new("arg_int8", DataType::Int8, false)),
+ Arc::new(Field::new("arg_int16", DataType::Int16, true)),
+ Arc::new(Field::new("arg_int32", DataType::Int32, false)),
+ ];
+
+ let ret_field = func
+ .return_field_from_args(ReturnFieldArgs {
+ arg_fields: args,
+ scalar_arguments: &[None, None, None],
+ })
+ .unwrap();
+
+ assert_eq!(ret_field.data_type(), &DataType::Date32);
+ assert!(ret_field.is_nullable());
+ }
+}
Review Comment:
I see NULL test cases already. If I am missing, something please let me
know. Thanks
`
query D
SELECT date_add(NULL::date, 1::int);
----
NULL
query D
SELECT date_add('2016-07-30'::date, NULL::int);
----
NULL
query D
SELECT date_add(NULL::date, NULL::int);`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
