BlakeOrth commented on code in PR #19108:
URL: https://github.com/apache/datafusion/pull/19108#discussion_r2599714346


##########
datafusion/core/src/execution/context/mod.rs:
##########
@@ -1232,6 +1252,28 @@ impl SessionContext {
         }
     }
 
+    fn parse_duration(duration: &str) -> Result<Duration> {

Review Comment:
   Should this method error if the input duration evaluates to 0s?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to