milenkovicm commented on PR #18739: URL: https://github.com/apache/datafusion/pull/18739#issuecomment-3622655096
> > I would leave up to you to make such decision, you're the one approving the PR; I personally struggle to see value of this PR at this moment. > > If it was only up to me, I'd say the change in this PR is appropriate and I'm good with moving forward with it. It's not only up to me though, we should also weight opinions of other contributors like you, and specially yours a as long tenured contributor to DataFusion. > > Would you be fine with a more contained change that uses `SessionConfig` instead of `ConfigOptions` as `PhysicalOptimizerRule::optimize` argument? Users do create their own rules, and that is very common. I have created quite few of them, hence my adamance we do not need this change. There is nothing you mentioned in https://github.com/apache/datafusion/pull/18168 that can't be done with the previous API. Requirements of #18168 are very vague as well. If you took `Extension` which @adriangb introduced, as your constructor parameter you'd be able to add your extensions dynamically, or bend it in any way you like. There is nothing in this change that deserves to be generalised and moved to core library function. If you like, we can take this at regular datafusion meeting, I have no problem with that. We can also take discussion about format of this PR as well, lack description or justification of breaking public API, or we can just revert the change and you do your specific use case things in your own code. Please let me know the which direction you would like to take, -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
