jizezhang commented on PR #19002: URL: https://github.com/apache/datafusion/pull/19002#issuecomment-3621729464
> Thank you so much @jizezhang -- this is a really nice PR. > > I had a few comments about the code, but I don't think any of them are required > > The only thing I think is needed for this PR is a test showing that the coalescing is happening within the > > I think you could perhaps follow the model of the existing tests in datafusion/physical-plan/src/repartition/mod.rs, and feed a bunch of small batches in (e.g. 5 rows) and then expect to get larger batches out the top > > Again thank you for your work on this (and thank you @martin-g for the review) Thanks a lot! I refactored the code based on your comment and also added unit test to test coalescing specifically. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
