adriangb commented on code in PR #19111:
URL: https://github.com/apache/datafusion/pull/19111#discussion_r2593332442
##########
datafusion/datasource-parquet/src/source.rs:
##########
@@ -299,7 +298,7 @@ impl ParquetSource {
pub fn new(table_schema: impl Into<TableSchema>) -> Self {
let table_schema = table_schema.into();
Self {
- projection: SplitProjection::unprojected(&table_schema),
+ projection:
ProjectionExprs::from_schema(table_schema.table_schema()),
Review Comment:
The logic here of creating this upfront even if it will often be replaced is
that the most important thing is that each time we create a `ParquetOpener`
(once per file) we do the minimum amount of compute. Pre-computing here it and
storing it in `ParquetSource` is the easiest way to do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
