cj-zhukov commented on code in PR #18946:
URL: https://github.com/apache/datafusion/pull/18946#discussion_r2591397615
##########
datafusion-examples/examples/builtin_functions/main.rs:
##########
@@ -67,12 +71,38 @@ impl FromStr for ExampleKind {
}
impl ExampleKind {
- const ALL: [Self; 3] = [Self::DateTime, Self::FunctionFactory,
Self::Regexp];
+ const ALL_VARIANTS: [Self; 4] = [
Review Comment:
I was actually considering using `strum` for this part, and I agree that it
would simplify the boilerplate. Since we try to keep dependencies minimal in
examples, I initially decided not to introduce it and instead went with the
more explicit implementation to keep the PR focused.
To avoid scope creep for this change, I’d prefer to finish this PR as-is.
After it is merged, I’d be happy to open a follow-up PR to refactor this
piece using `strum`, especially since it’s already part of the workspace. That
would make the examples cleaner and easier to maintain.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
