adriangb commented on code in PR #19094:
URL: https://github.com/apache/datafusion/pull/19094#discussion_r2590250108
##########
datafusion/core/tests/physical_optimizer/partition_statistics.rs:
##########
@@ -418,7 +417,7 @@ mod test {
let expected_stats = Statistics {
num_rows: Precision::Inexact(4),
- total_byte_size: Precision::Inexact(220),
Review Comment:
Indeed this is the case:
https://github.com/apache/datafusion/blob/388db0e52f8e31256ba6185cfb9605c1e678c74c/datafusion/datasource-parquet/src/metadata.rs#L253
So the initial collection just adds up the size of the row groups (in
Parquet). But presumably we want the size to be the size returned by the scan,
not the size of the scan itself. So this is wrong, it should be doing the same
calculation as `ProjectionExprs`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
