adriangb commented on code in PR #19094:
URL: https://github.com/apache/datafusion/pull/19094#discussion_r2590236048


##########
datafusion/core/tests/physical_optimizer/partition_statistics.rs:
##########
@@ -418,7 +417,7 @@ mod test {
 
         let expected_stats = Statistics {
             num_rows: Precision::Inexact(4),
-            total_byte_size: Precision::Inexact(220),

Review Comment:
   I'm trying to understand why these numbers changed. I think the issue is 
that the way the row sizes are calculated when the statistics are initially 
computed doesn't match how the row sizes are calculated by `ProjectionExprs`. 
I'm guessing they're measuring different things (parquet row size vs arrow row 
size??). Unfortunately the `Statistics` struct doesn't have much in terms of 
documentation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to