codetyri0n commented on code in PR #18990:
URL: https://github.com/apache/datafusion/pull/18990#discussion_r2583845247
##########
datafusion/functions/src/datetime/date_part.rs:
##########
@@ -240,23 +314,43 @@ impl ScalarUDFImpl for DatePartFunc {
}
}
+fn adjust_timestamp_array<T: ArrowTimestampType>(
+ array: &ArrayRef,
+ tz: Tz,
+) -> Result<ArrayRef> {
+ let mut builder = PrimitiveBuilder::<T>::new();
+ let primitive_array = as_primitive_array::<T>(array)?;
+ for ts_opt in primitive_array.iter() {
+ match ts_opt {
+ None => builder.append_null(),
+ Some(ts) => {
+ let adjusted_ts = adjust_to_local_time::<T>(ts, tz)?;
+ builder.append_value(adjusted_ts);
+ }
+ }
+ }
+ Ok(Arc::new(builder.finish()))
+}
+
fn is_epoch(part: &str) -> bool {
let part = part_normalization(part);
matches!(part.to_lowercase().as_str(), "epoch")
}
-// Try to remove quote if exist, if the quote is invalid, return original
string and let the downstream function handle the error
Review Comment:
I had initially planned to give a better description for it but missed it,
will revert back to how it was originally
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
