2010YOUY01 commented on PR #18908: URL: https://github.com/apache/datafusion/pull/18908#issuecomment-3601126183
Thank you for working on this. I feel the additional complexity here outweighs the benefits, and I’d prefer to keep things simpler for maintainability. (Or we may decide to drop it, since this is a fairly minor issue) To properly unify error-message generation and the validator, I think we’d need to update `sqllogictest` upstream. Otherwise we risk carrying local complexity for limited gain. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
