alamb commented on code in PR #18988:
URL: https://github.com/apache/datafusion/pull/18988#discussion_r2574814078
##########
datafusion/common-runtime/src/common.rs:
##########
@@ -44,7 +44,7 @@ impl<R: 'static> SpawnedTask<R> {
R: Send,
{
// Ok to use spawn here as SpawnedTask handles aborting/cancelling the
task on Drop
- #[allow(clippy::disallowed_methods)]
+ #[expect(clippy::disallowed_methods)]
Review Comment:
❤️
##########
datafusion/common/src/config.rs:
##########
@@ -157,12 +157,10 @@ macro_rules! config_namespace {
// $(#[allow(deprecated)])?
{
$(let value = $transform(value);)? // Apply
transformation if specified
- #[allow(deprecated)]
Review Comment:
it may have been needed for code that was subsequently updated but the
`allow(deprecated)` annotation was not. That is why I like the
`expect(deprecated)` style as then the compiler will tell you when it is no
longer actually needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
