Jefffrey commented on code in PR #18988:
URL: https://github.com/apache/datafusion/pull/18988#discussion_r2573001540
##########
datafusion/common/src/scalar/mod.rs:
##########
@@ -6331,7 +6331,7 @@ mod tests {
#[test]
// despite clippy claiming they are useless, the code doesn't compile
otherwise.
- #[allow(clippy::useless_vec)]
+ #[expect(clippy::useless_vec)]
Review Comment:
Have we tried removing this lint and fixing the clippy lint as it occurs to
see if we actually need this expect?
##########
datafusion/common/src/config.rs:
##########
@@ -157,12 +157,10 @@ macro_rules! config_namespace {
// $(#[allow(deprecated)])?
{
$(let value = $transform(value);)? // Apply
transformation if specified
- #[allow(deprecated)]
Review Comment:
Hmm I wonder if there was a historical reason these allow deprecations were
present; was it anticipating future compatibility? 🤔
##########
datafusion/common/src/error.rs:
##########
@@ -939,10 +939,8 @@ macro_rules! make_error {
// This macro generates a use or all of them in case they are
needed
// so we allow unused code to avoid warnings when they are not used
Review Comment:
```suggestion
```
Remove this comment, assuming we do now use all of them within this crate 🤔
##########
datafusion/common/src/stats.rs:
##########
@@ -979,7 +979,6 @@ mod tests {
let precision: Precision<ScalarValue> =
Precision::Exact(ScalarValue::Int64(Some(42)));
// Clippy would complain about this if it were Copy
Review Comment:
```suggestion
```
##########
datafusion/common/src/file_options/parquet_writer.rs:
##########
@@ -27,7 +27,6 @@ use crate::{
use arrow::datatypes::Schema;
use parquet::arrow::encode_arrow_schema;
// TODO: handle once deprecated
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
