Jefffrey commented on code in PR #18983: URL: https://github.com/apache/datafusion/pull/18983#discussion_r2572706904
########## datafusion/physical-plan/src/lib.rs: ########## @@ -26,6 +25,8 @@ // https://github.com/apache/datafusion/issues/18503 #![deny(clippy::needless_pass_by_value)] Review Comment: Unrelated to this PR, but @2010YOUY01 were we supposed to remove these denys for needless_pass_by_value in each of the lib.rs as part of #18904? (Doesn't need to be addressed by this PR, just something it made it realize) Edit: raised https://github.com/apache/datafusion/pull/18996 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
