Jefffrey commented on code in PR #18983:
URL: https://github.com/apache/datafusion/pull/18983#discussion_r2572705211
##########
datafusion/physical-plan/src/render_tree.rs:
##########
@@ -31,7 +31,7 @@ use crate::{DisplayFormatType, ExecutionPlan};
// TODO: It's never used.
/// Represents a 2D coordinate in the rendered tree.
/// Used to track positions of nodes and their connections.
-#[allow(dead_code)]
+#[expect(dead_code)]
Review Comment:
Can we place these on the fields themselves instead of the struct, to make
it clear its the fields that are unused?
##########
datafusion/physical-plan/src/lib.rs:
##########
@@ -26,6 +25,8 @@
// https://github.com/apache/datafusion/issues/18503
#![deny(clippy::needless_pass_by_value)]
Review Comment:
Unrelated to this PR, but @2010YOUY01 were we supposed to remove these denys
for needless_pass_by_value in each of the lib.rs as part of #18904?
(Doesn't need to be addressed by this PR, just something it made it realize)
##########
datafusion/physical-plan/src/lib.rs:
##########
@@ -14,7 +14,6 @@
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.
-
Review Comment:
This lost newline is causing the header CI check to fail
##########
datafusion/physical-plan/src/execution_plan.rs:
##########
@@ -1534,7 +1534,7 @@ mod tests {
/// A compilation test to ensure that the `ExecutionPlan::name()` method
can
/// be called from a trait object.
/// Related ticket: https://github.com/apache/datafusion/pull/11047
- #[allow(dead_code)]
+ #[expect(unused)]
Review Comment:
```suggestion
#[expect(dead_code)]
```
##########
datafusion/physical-plan/src/joins/piecewise_merge_join/exec.rs:
##########
@@ -272,7 +272,7 @@ pub struct PiecewiseMergeJoinExec {
left_child_plan_required_order: LexOrdering,
/// The right sort order, descending for `<`, `<=` operations + ascending
for `>`, `>=` operations
/// Unsorted for mark joins
- #[allow(unused)]
+ #[expect(unused)]
Review Comment:
```suggestion
#[expect(dead_code)]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
