xitep commented on PR #2101:
URL: 
https://github.com/apache/datafusion-sqlparser-rs/pull/2101#issuecomment-3590266103

   > so that it would be a bit confusing going forward having code specific to 
the dialect
   
   i would have a draft of an `OracleDialect` 
[here](https://github.com/xitep/datafusion-sqlparser-rs/commit/b8c8272c2b50fbe14470a2a75aa22747ad51fae7)
 ... would you like to have it rather as a separate PR (or include in into this 
one?) there's surely quite some work left on full oracle support (eg. [string 
literals with a 
quote_delimiter](https://docs.oracle.com/en/database/oracle/oracle-database/21/sqlrf/Literals.html#GUID-1824CBAA-6E16-4921-B2A6-112FB02248DA))
 but it would be a start at least.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to