2010YOUY01 commented on code in PR #18954:
URL: https://github.com/apache/datafusion/pull/18954#discussion_r2571230489
##########
datafusion/common/src/config.rs:
##########
@@ -2786,6 +2787,14 @@ config_namespace! {
/// The default behaviour depends on the
`datafusion.catalog.newlines_in_values` setting.
pub newlines_in_values: Option<bool>, default = None
pub compression: CompressionTypeVariant, default =
CompressionTypeVariant::UNCOMPRESSED
+ /// Compression level for the output file. The valid range depends on
the
+ /// compression algorithm:
+ /// - ZSTD: 1 to 22 (default: 3)
+ /// - GZIP: 0 to 10 (default: varies by implementation)
+ /// - BZIP2: 0 to 9 (default: 6)
+ /// - XZ: 0 to 9 (default: 6)
+ /// If not specified, the default level for the compression algorithm
is used.
+ pub compression_level: Option<u32>, default = None
Review Comment:
Should we include level inside compression type `CompressionTypeVariant`,
like
```
pub enum CompressionTypeVariant {
/// Gzip-ed file, level 1–9
Gzip { level: u32 },
....
```
This introduces some API changes, but I think it's cleaner and better for
the long term 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
