maxburke commented on code in PR #18950:
URL: https://github.com/apache/datafusion/pull/18950#discussion_r2567183270
##########
datafusion/functions/src/encoding/inner.rs:
##########
@@ -553,3 +567,29 @@ fn decode(args: &[ColumnarValue]) -> Result<ColumnarValue>
{
}?;
decode_process(expression, encoding)
}
+
+#[cfg(test)]
+mod tests {
+ #[test]
+ fn test_encode_fsb() {
Review Comment:
>From what I can tell this PR doesn't actually fix anything
How so? Before, calling encode on fixedsizebinary types would have returned
an unsupported data type error.
We've been using in production since April when we first made the change:
https://github.com/urbanlogiq/arrow-datafusion/commit/9dfd56128772d8d7ffff59f31b7890a7a0499724
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
