timsaucer commented on code in PR #18672:
URL: https://github.com/apache/datafusion/pull/18672#discussion_r2556711785
##########
datafusion/ffi/src/plan_properties.rs:
##########
@@ -176,6 +178,10 @@ impl TryFrom<FFI_PlanProperties> for PlanProperties {
type Error = DataFusionError;
fn try_from(ffi_props: FFI_PlanProperties) -> Result<Self, Self::Error> {
+ if (ffi_props.library_marker_id)() == crate::get_library_marker_id() {
Review Comment:
It's not an assertion, but a check. I think there's plenty of documentation
in (1) docstring for `library_marker_id` (2) docstring for
`get_library_marker_id` and (3) the `README.md` that I don't think we need an
additional inline doc for every time we call this function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
