comphead commented on code in PR #18672:
URL: https://github.com/apache/datafusion/pull/18672#discussion_r2554638866
##########
datafusion/ffi/src/schema_provider.rs:
##########
@@ -234,9 +241,14 @@ pub struct ForeignSchemaProvider(pub FFI_SchemaProvider);
unsafe impl Send for ForeignSchemaProvider {}
unsafe impl Sync for ForeignSchemaProvider {}
-impl From<&FFI_SchemaProvider> for ForeignSchemaProvider {
+impl From<&FFI_SchemaProvider> for Arc<dyn SchemaProvider + Send> {
fn from(provider: &FFI_SchemaProvider) -> Self {
- Self(provider.clone())
+ if (provider.library_marker_id)() == crate::get_library_marker_id() {
Review Comment:
same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
