renato2099 commented on code in PR #18672:
URL: https://github.com/apache/datafusion/pull/18672#discussion_r2554373507
##########
datafusion-examples/examples/ffi/ffi_module_loader/src/main.rs:
##########
@@ -49,13 +49,13 @@ async fn main() -> Result<()> {
))?();
// In order to access the table provider within this executable, we need to
- // turn it into a `ForeignTableProvider`.
- let foreign_table_provider: ForeignTableProvider =
(&ffi_table_provider).into();
+ // turn it into a `TableProvider`.
Review Comment:
just for my own learning/understanding as well
> This will be a breaking change from 51 -> 52. Actually this is the first
of a series of 9 total PRs for a massive overhaul of the FFI work.
must all of those PRs land in the same version? or is it safe/ok that some
of them are released earlier than others?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
