pepijnve commented on PR #18183: URL: https://github.com/apache/datafusion/pull/18183#issuecomment-3568147375
> is that ok by you? I had written a reply already, but it seems to have gotten gobbled up somewhere. Take 2. No objection at all to keeping the PR separate. I was having a hard time describing what I had in mind in plain English so I just went for code instead. Not blocking for this PR at all. All the comments are non-public code anyway, so no problem in postponing. The implementation itself is ok I think. Just the issue of the panic that needs to be resolved when the case expression is a dictionary array. The test case in question has been merged in the mean time on `main`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
