xitep commented on code in PR #2090:
URL: 
https://github.com/apache/datafusion-sqlparser-rs/pull/2090#discussion_r2514162666


##########
src/ast/spans.rs:
##########
@@ -2535,4 +2542,22 @@ ALTER TABLE users
         assert_eq!(stmt_span.start, (2, 13).into());
         assert_eq!(stmt_span.end, (4, 11).into());
     }
+
+    #[test]
+    fn test_update_statement_span() {

Review Comment:
   i fear i'm affected by #2050 wrt to asserting the end of the insert/replace 
statements. would you like me to look at a solution for that? (most likely i'd 
propose 
[`Values`](https://docs.rs/sqlparser/latest/sqlparser/ast/struct.Values.html) 
to receive a `span: Span` attribute.)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to