cfmcgrady commented on code in PR #2643:
URL: https://github.com/apache/datafusion-comet/pull/2643#discussion_r2476436911
##########
native/spark-expr/src/array_funcs/array_insert.rs:
##########
@@ -198,114 +198,124 @@ fn array_insert<O: OffsetSizeTrait>(
pos_array: &ArrayRef,
legacy_mode: bool,
) -> DataFusionResult<ColumnarValue> {
- // The code is based on the implementation of the array_append from the
Apache DataFusion
- //
https://github.com/apache/datafusion/blob/main/datafusion/functions-nested/src/concat.rs#L513
- //
- // This code is also based on the implementation of the array_insert from
the Apache Spark
- //
https://github.com/apache/spark/blob/branch-3.5/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala#L4713
+ // Implementation aligned with Arrow's half-open offset ranges and Spark
semantics.
Review Comment:
The version fixed by ChatGPT :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
