parthchandra commented on PR #2643: URL: https://github.com/apache/datafusion-comet/pull/2643#issuecomment-3464212646
> hi @parthchandra > > > Null checking is expensive and should be avoided if possible > > Yes, I completely agree that unnecessary null checking should be avoided for performance reasons. > > > the pattern has been for the caller to check if the value is null when needed > > For `ColumnVector`’s `getXXX` methods, their documentation clearly specifies the null handling requirements for each method. Spark has addressed this in [apache/spark#20455](https://github.com/apache/spark/pull/20455), where the corresponding changes were made. I stand corrected. This does make the implementations consistent with Spark. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
