Jefffrey commented on PR #18324: URL: https://github.com/apache/datafusion/pull/18324#issuecomment-3460505802
Some things I noticed: - Toggle has 3 states (and 3 different icons) - Theme is remembered per page, not globally; e.g. if I set light mode (default is dark) on home/index page, and I navigate to another page, that page will be dark but when I navigate back to home it'll be light - The `More` menu on the navbar doesn't play well given it's length, might be better off removing it - I also prefer removing the other links on the navbar (e.g. License, Donate) given they are also at the top of the sidebar; either keep the sidebar ones or keep only the navbar ones to remove this duplication -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
