paleolimbot commented on code in PR #18136:
URL: https://github.com/apache/datafusion/pull/18136#discussion_r2462554412
##########
datafusion/physical-expr/src/planner.rs:
##########
@@ -291,12 +291,14 @@ pub fn create_physical_expr(
Expr::Cast(Cast { expr, data_type }) => expressions::cast(
create_physical_expr(expr, input_dfschema, execution_props)?,
input_schema,
- data_type.clone(),
+ // TODO: this drops extension metadata associated with the cast
+ data_type.data_type().clone(),
Review Comment:
I updated this to error at the logical expr -> physical expr stage if there
is metadata on the cast field. I think this is better than dropping it (and
won't break any existing code because before this PR such a cast could not
exist).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
