shehabgamin commented on PR #18174: URL: https://github.com/apache/datafusion/pull/18174#issuecomment-3425192937
> > I wonder if we address #18175 then will we still need a separate `ceil` function for Spark? What differences are there with the DataFusion version now? 🤔 > > I was not aware of the attempts made with #15958 and on having a look the return type has been kept the same as the input type (and for floor it is i128) so I am now doubtful whether my conclusion on what it should return is correct. Would love to have the thoughts of @shehabgamin and @andygrove for some clarity. @codetyri0n You can port over the implementation from Sail: https://github.com/lakehq/sail/blob/main/crates/sail-function/src/scalar/math/spark_ceil_floor.rs It should be a straightforward port over. Further, we have some additional tests not covered by the Spark test suite here: https://github.com/lakehq/sail/blob/main/python/pysail/tests/spark/function/test_ceil.txt https://github.com/lakehq/sail/blob/main/python/pysail/tests/spark/function/test_floor.txt -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
