comphead commented on code in PR #18087:
URL: https://github.com/apache/datafusion/pull/18087#discussion_r2436599412
##########
datafusion/spark/src/function/string/concat.rs:
##########
@@ -122,13 +127,13 @@ fn spark_concat(args: ScalarFunctionArgs) ->
Result<ColumnarValue> {
apply_null_mask(result, null_mask)
}
-/// Compute NULL mask for the arguments
-/// Returns None if all scalars and any is NULL, or a Vector of
-/// boolean representing the null mask for incoming arrays
+/// Compute NULL mask for the arguments using NullBuffer::union
+/// Returns None if all scalars and any is NULL, or an Option of NullBuffer
+/// representing the combined null mask for incoming arrays
fn compute_null_mask(
args: &[ColumnarValue],
number_rows: usize,
-) -> Result<Option<Vec<bool>>> {
+) -> Result<Option<Option<NullBuffer>>> {
Review Comment:
Thanks @Jefffrey I agree, originally I thought introducing another enum just
for this function would be too much, but I think it would be better having enum
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
