alamb commented on code in PR #17888:
URL: https://github.com/apache/datafusion/pull/17888#discussion_r2421884747
##########
datafusion/core/tests/parquet/filter_pushdown.rs:
##########
@@ -632,7 +632,7 @@ async fn predicate_cache_pushdown_default() ->
datafusion_common::Result<()> {
#[tokio::test]
async fn predicate_cache_pushdown_disable() -> datafusion_common::Result<()> {
// Can disable the cache even with filter pushdown by setting the size to
0. In this case we
- // expect the inner records are reported but no records are read from the
cache
+ // no records are read from the cache and no metrics are reported
Review Comment:
This is due to @nuno-faria 's work to close ❤️
- https://github.com/apache/arrow-rs/issues/8307
I was somewhat surprised that there are no metrics at all reported, but I
think it makes sense as the reporting is currently only done by the cache
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
