iffyio commented on code in PR #2029:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2029#discussion_r2375735425
##########
tests/sqlparser_common.rs:
##########
@@ -17246,3 +17246,47 @@ fn parse_invisible_column() {
_ => panic!("Unexpected statement {stmt}"),
}
}
+
+#[test]
+fn parse_create_index_using_before_on() {
+ let sql = "CREATE INDEX idx_name USING BTREE ON table_name (col1)";
+ // Can't use `verified_stmt` here as the USING will be placed after the
`ON` clause
+ match all_dialects().parse_sql_statements(sql).unwrap()[0].clone() {
Review Comment:
for the tests, I think we can use `one_statement_parses_to()` instead so
that the test covers the display impl as well?
Also can we merge both test functions into the same
`parse_create_index_using()` or similar function - since they cover the same
feature
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
