geoffreyclaude commented on PR #17633: URL: https://github.com/apache/datafusion/pull/17633#issuecomment-3352448161
Hi @theirix! @alamb [linked me](https://discord.com/channels/885562378132000778/1419669402508464280/1422287535484440627) to your PR as I'm looking to do something very similar (extend the DataFusion SQL to support MatchRecognize in an extension.) From what I understand of your code, it only works if the `TABLESAMPLE` is at the root of the query, so any `TABLESAMPLE` inside a CTE or sides of a JOIN won't get transformed, is that correct? I have a work in progress implementation of a similar idea, but which allows injecting any number of custom relation planners, and supports nested custom relations as well. I've added your `TABLESAMPLE` example in it and it works great (and a mini-`MATCH_RECOGNIZE` for @alamb too 😄) If you want to give it a look, the draft PR is https://github.com/apache/datafusion/pull/17843 . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
