dqkqd commented on PR #17926: URL: https://github.com/apache/datafusion/pull/17926#issuecomment-3373384126
> Thanks @dqkqd what concerns me is no tests failed on this change Yes, we currently have no test covering the failure case of `try_new_with_schema`. I didn't add one because neither `Aggregate::try_new_with_schema` nor `Projection::try_new_with_schema` has tests for the error path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
