vegarsti commented on code in PR #17777:
URL: https://github.com/apache/datafusion/pull/17777#discussion_r2380977718
##########
datafusion/common/src/dfschema.rs:
##########
@@ -2106,7 +2118,7 @@ mod tests {
Field::new(
"timestamp_field",
DataType::Timestamp(
- arrow::datatypes::TimeUnit::Microsecond,
+ TimeUnit::Microsecond,
Review Comment:
Seems like the convention here is to not import the type, but to use the
qualified path `arrow::datatypes::TimeUnit::Microsecond` - maybe remove that
import on line 1335?
##########
datafusion/common/src/dfschema.rs:
##########
@@ -1327,6 +1332,7 @@ pub fn qualified_name(qualifier: Option<&TableReference>,
name: &str) -> String
#[cfg(test)]
mod tests {
+ use arrow::datatypes::TimeUnit;
Review Comment:
See https://github.com/apache/datafusion/pull/17777#discussion_r2380977718
about removing this import. If you still want to keep it, seems like the cargo
check wants it below the import on the next line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
