cfmcgrady commented on code in PR #2425:
URL: https://github.com/apache/datafusion-comet/pull/2425#discussion_r2425100105
##########
spark/src/test/spark-3.5/org/apache/spark/sql/CometToPrettyStringSuite.scala:
##########
@@ -43,7 +47,8 @@ class CometToPrettyStringSuite extends CometFuzzTestBase {
val analyzed = spark.sessionState.analyzer.execute(plan)
val result: DataFrame = Dataset.ofRows(spark, analyzed)
CometCast.isSupported(field.dataType, DataTypes.StringType,
Some(spark.sessionState.conf.sessionLocalTimeZone), CometEvalMode.TRY) match {
- case _: Compatible => checkSparkAnswerAndOperator(result)
+ case _: Compatible if
cometScanTypeChecker.isTypeSupported(field.dataType, scanImpl,
ListBuffer.empty) =>
Review Comment:
The `COMET_NATIVE_SCAN_IMPL` configuration will be reset before the test
starts, so we should get its value at runtime. Therefore, I will keep the
current implementation.
https://github.com/apache/datafusion-comet/blob/0ddd89fe0b23fa0c37f4a18c4cbbef12a2674067/spark/src/test/scala/org/apache/comet/CometFuzzTestBase.scala#L78-L95
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
