ctsk commented on PR #18044:
URL: https://github.com/apache/datafusion/pull/18044#issuecomment-3404912106
> Would you be able to post the results of the benchmark as well, for
visibility?
Of course! Please keep in mind that this is a very specific workload and not
broader regression testing
<details>
<summary>Benchmark results</summary>
```
min_max_bytes/10 time: [2.1324 ms 2.1351 ms 2.1383 ms]
thrpt: [38.311 Melem/s 38.369 Melem/s 38.417
Melem/s]
change:
time: [-2.4648% -1.9429% -1.4676%] (p = 0.00 <
0.05)
thrpt: [+1.4894% +1.9814% +2.5270%]
Performance has improved.
Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) high severe
min_max_bytes/20 time: [4.1660 ms 4.1842 ms 4.2046 ms]
thrpt: [38.967 Melem/s 39.157 Melem/s 39.328
Melem/s]
change:
time: [-27.329% -26.771% -26.207%] (p = 0.00 <
0.05)
thrpt: [+35.514% +36.558% +37.607%]
Performance has improved.
Found 4 outliers among 100 measurements (4.00%)
3 (3.00%) high mild
1 (1.00%) high severe
min_max_bytes/50 time: [11.599 ms 11.635 ms 11.671 ms]
thrpt: [35.097 Melem/s 35.206 Melem/s 35.314
Melem/s]
change:
time: [-50.148% -49.739% -49.331%] (p = 0.00 <
0.05)
thrpt: [+97.359% +98.963% +100.59%]
Performance has improved.
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild
min_max_bytes/100 time: [24.422 ms 24.512 ms 24.611 ms]
thrpt: [33.286 Melem/s 33.420 Melem/s 33.544
Melem/s]
change:
time: [-68.470% -68.259% -68.041%] (p = 0.00 <
0.05)
thrpt: [+212.90% +215.05% +217.16%]
Performance has improved.
Found 8 outliers among 100 measurements (8.00%)
6 (6.00%) high mild
2 (2.00%) high severe
min_max_bytes/150 time: [37.990 ms 38.069 ms 38.150 ms]
thrpt: [32.210 Melem/s 32.278 Melem/s 32.346
Melem/s]
change:
time: [-74.820% -74.358% -73.932%] (p = 0.00 <
0.05)
thrpt: [+283.61% +289.98% +297.14%]
Performance has improved.
Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) high mild
min_max_bytes/200 time: [49.525 ms 49.595 ms 49.664 ms]
thrpt: [32.990 Melem/s 33.036 Melem/s 33.082
Melem/s]
change:
time: [-85.623% -85.596% -85.569%] (p = 0.00 <
0.05)
thrpt: [+592.93% +594.25% +595.56%]
Performance has improved.
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) low mild
Benchmarking min_max_bytes/300: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase
target time to 7.7s, or reduce sample count to 60.
min_max_bytes/300 time: [76.764 ms 76.883 ms 77.005 ms]
thrpt: [31.915 Melem/s 31.965 Melem/s 32.015
Melem/s]
change:
time: [-90.252% -90.233% -90.214%] (p = 0.00 <
0.05)
thrpt: [+921.91% +923.83% +925.85%]
Performance has improved.
Benchmarking min_max_bytes/400: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase
target time to 10.0s, or reduce sample count to 40.
min_max_bytes/400 time: [100.19 ms 100.39 ms 100.62 ms]
thrpt: [32.567 Melem/s 32.640 Melem/s 32.707
Melem/s]
change:
time: [-92.854% -92.835% -92.815%] (p = 0.00 <
0.05)
thrpt: [+1291.9% +1295.6% +1299.3%]
Performance has improved.
Found 5 outliers among 100 measurements (5.00%)
4 (4.00%) high mild
1 (1.00%) high severe
Benchmarking min_max_bytes/500: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase
target time to 12.3s, or reduce sample count to 40.
min_max_bytes/500 time: [123.16 ms 123.36 ms 123.57 ms]
thrpt: [33.148 Melem/s 33.204 Melem/s 33.259
Melem/s]
change:
time: [-94.422% -94.398% -94.376%] (p = 0.00 <
0.05)
thrpt: [+1678.1% +1685.1% +1692.7%]
Performance has improved.
Found 7 outliers among 100 measurements (7.00%)
7 (7.00%) high mild
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]