wForget commented on PR #2450: URL: https://github.com/apache/datafusion-comet/pull/2450#issuecomment-3329063499
@mbutrovich @andygrove Thank you for your review, and sorry for missing the `How are these changes tested?` information. This improvements come from two unexpected checks in the failing [CometExpressionSuite.'explain comet'](https://github.com/apache/datafusion-comet/actions/runs/17972563061/job/51118427453) test case: [https://github.com/apache/datafusion-comet/blob/a806bf0448f03f5ee6e6b6c119751e2d1365c909/spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala#L1928](https://github.com/apache/datafusion-comet/blob/a806bf0448f03f5ee6e6b6c119751e2d1365c909/spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala#L1928) [https://github.com/apache/datafusion-comet/blob/a806bf0448f03f5ee6e6b6c119751e2d1365c909/spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala#L1934-L1936](https://github.com/apache/datafusion-comet/blob/a806bf0448f03f5ee6e6b6c119751e2d1365c909/spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala#L1934-L1936) 1. The first failure occurs because of the extra message `CometSparkRowToColumnar is not supported`. The error looked like this: ``` - explain comet *** FAILED *** (720 milliseconds) Comet shuffle is not enabled: spark.comet.exec.shuffle.enabled is not enabled CometSparkRowToColumnar is not supported != Comet shuffle is not enabled: spark.comet.exec.shuffle.enabled is not enabled (case-insensitive comparison) (CometTestBase.scala:299) ``` 2. The second failure happens because `ReusedExchangeExec` exists in the SparkPlan, which causes the expected `Comet shuffle is not enabled...` message to be missing. The error looked like this: ``` Cast from CalendarIntervalType to StringType is not supported != Cast from CalendarIntervalType to StringType is not supported Comet shuffle is not enabled: spark.comet.exec.shuffle.enabled is not enabled ``` After this fix, these checks work as expected -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
