andygrove commented on code in PR #2538:
URL: https://github.com/apache/datafusion-comet/pull/2538#discussion_r2414687422
##########
native/core/src/execution/memory_pools/config.rs:
##########
@@ -59,11 +59,12 @@ pub(crate) fn parse_memory_pool_config(
memory_limit: i64,
memory_limit_per_task: i64,
) -> CometResult<MemoryPoolConfig> {
- let pool_size = memory_limit as usize;
+ let pool_size_global = memory_limit as usize;
+ let pool_size_per_task = memory_limit_per_task as usize;
let memory_pool_config = if off_heap_mode {
match memory_pool_type.as_str() {
- "default" | "fair_unified" => {
- MemoryPoolConfig::new(MemoryPoolType::FairUnified, pool_size)
+ "fair_unified" => {
+ MemoryPoolConfig::new(MemoryPoolType::FairUnified,
pool_size_per_task)
Review Comment:
this is a functional change - each task is now limited to the per-task limit
rather than a global limit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
