andygrove commented on code in PR #2538:
URL: https://github.com/apache/datafusion-comet/pull/2538#discussion_r2421930039
##########
spark/src/main/scala/org/apache/comet/CometExecIterator.scala:
##########
@@ -318,3 +262,74 @@ class CometExecIterator(
nativeLib.logMemoryUsage(s"task_memory_spark_$threadId", sparkTaskMemory)
}
}
+
+object CometExecIterator extends Logging {
+
+ def getMemoryConfig(conf: SparkConf): MemoryConfig = {
+ val numCores = numDriverOrExecutorCores(conf).toFloat
+ val coresPerTask = conf.get("spark.task.cpus", "1").toFloat
Review Comment:
No, this is an intConf. I updated this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
