alan910127 commented on issue #17158: URL: https://github.com/apache/datafusion/issues/17158#issuecomment-3342920407
Hi @alamb, after taking a closer look at our implementation, I noticed that recursion is currently handled by the `expr.rewrite()` call, which makes it nontrivial to apply rules like “let’s try the commutative law and see if it simplifies” similar to how it's done in LLVM’s `InstructionSimplify` module. Do you have any thoughts on this? One approach I can think of is to manually recurse in a new `BinaryOpSimplifier`, and return `Transformed::complete` to signal stopping the recursion (since we’ve already handled it). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
