alamb commented on PR #17871: URL: https://github.com/apache/datafusion/pull/17871#issuecomment-3368119752
> I do wonder if it is possible to merge this code with DataFusion avg, perhaps using generics to control the count type and bool flag for ansi mode in the future, to reduce duplication? Or would it be not worth the effort or are there more differences than just those two? I suggest that initially we accept there is a second `avg` and as we consolidate more of this functionalty in datafusion-spark, we can do things like consolidate the implementations- More background here https://github.com/apache/datafusion/issues/15914#issuecomment-3368118452 Perhaps it would be good to file a ticket to track the idea of consolidation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
