comphead commented on code in PR #17956:
URL: https://github.com/apache/datafusion/pull/17956#discussion_r2414114391
##########
datafusion-examples/examples/advanced_parquet_index.rs:
##########
@@ -555,25 +555,25 @@ impl ParquetFileReaderFactory for
CachedParquetFileReaderFactory {
fn create_reader(
&self,
_partition_index: usize,
- file_meta: FileMeta,
+ file: PartitionedFile,
Review Comment:
1 nit: we probably can name it as `partition_file` to be the same format as
other function params
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
