parthchandra commented on PR #2554: URL: https://github.com/apache/datafusion-comet/pull/2554#issuecomment-3398763991
> > Why do we need a new config for this? Isn't Spark's config sufficient? > > The goal is to require the user to opt-in to enabling Comet if Spark is in on-heap mode, because running Comet in on-heap mode is not recommended for production use. Hmm. I feel that we have too many configs already and there may already be confusion about memory settings for Comet. I'm not saying we shouldn't have this config, but we do need to start simplifying things for end users soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
