AdamGS commented on code in PR #17808:
URL: https://github.com/apache/datafusion/pull/17808#discussion_r2387457372
##########
datafusion/physical-plan/src/joins/sort_merge_join/stream.rs:
##########
@@ -1994,6 +1996,8 @@ fn is_join_arrays_equal(
DataType::BinaryView => compare_value!(BinaryViewArray),
DataType::FixedSizeBinary(_) =>
compare_value!(FixedSizeBinaryArray),
DataType::LargeBinary => compare_value!(LargeBinaryArray),
+ DataType::Decimal32(..) => compare_value!(Decimal32Array),
+ DataType::Decimal64(..) => compare_value!(Decimal64Array),
Review Comment:
Sure, I'll add it. Through this work I've noticed a few places where it was
omitted, but I've yet to find a reason or even a failing test that would
explain it, usually its just a matter of adding a branch to a match statement
like here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
