mbutrovich opened a new pull request, #2528:
URL: https://github.com/apache/datafusion-comet/pull/2528

   ## Rationale for this change
   
   <!--
    Why are you proposing this change? If this is already explained clearly in 
the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your 
changes and offer better suggestions for fixes.  
   -->
   
   I was inspired by [Russell's recent 
talk](https://www.youtube.com/watch?v=kJaD0WuQ1Bg) and wanted to visit the 
abstraction layer at which Comet integrates with Iceberg. We have the 
`iceberg_compat` codepath for Iceberg integration, but this requires code 
changes in Iceberg to integrate with partition reader factories. Instead, this 
prototype works at the `FileScanTask` layer after planning. This prototype 
starts us toward a path of fully-native Iceberg scans to match our Parquet 
logic with `native_datafusion` scans without any changes in Iceberg code.
   
   ## What changes are included in this PR?
   
   <!--
   There is no need to duplicate the description in the issue here but it is 
sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   - New `CometIcebergNativeScanExec` node on the Scala side.
   - Use reflection to extract scan properties, mostly `FileScanTask`s and 
serialize to native code.
   - New `IcebergScanExec` on native side that uses `FileScanTask`s to perform 
reads in `iceberg-rust`.
   
   ## How are these changes tested?
   
   <!--
   We typically require tests for all PRs in order to:
   1. Prevent the code from being accidentally broken by subsequent changes
   2. Serve as another way to document the expected behavior of the code
   
   If tests are not included in your PR, please explain why (for example, are 
they covered by existing tests)?
   -->
   
   New `CometIcebergNativeSuite`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to