andygrove commented on code in PR #2421:
URL: https://github.com/apache/datafusion-comet/pull/2421#discussion_r2417770899
##########
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##########
@@ -2970,6 +2968,26 @@ class CometExpressionSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
}
}
+ test("ANSI support for integral divide (division by zero)") {
+ val data = Seq((Integer.MIN_VALUE, 0))
+ withSQLConf(SQLConf.ANSI_ENABLED.key -> "true") {
Review Comment:
Could you also test the for non ANSI case to make sure we see the correct
behavior for these inputs
##########
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##########
@@ -2970,6 +2968,26 @@ class CometExpressionSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
}
}
+ test("ANSI support for integral divide (division by zero)") {
+ val data = Seq((Integer.MIN_VALUE, 0))
+ withSQLConf(SQLConf.ANSI_ENABLED.key -> "true") {
Review Comment:
Could you also test for the non-ANSI case to make sure we see the correct
behavior for these inputs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
