Omega359 commented on code in PR #18017:
URL: https://github.com/apache/datafusion/pull/18017#discussion_r2422963167
##########
datafusion/functions/src/datetime/now.rs:
##########
@@ -80,7 +80,7 @@ impl ScalarUDFImpl for NowFunc {
fn return_field_from_args(&self, _args: ReturnFieldArgs) ->
Result<FieldRef> {
Ok(Field::new(
self.name(),
- Timestamp(Nanosecond, Some("+00:00".into())),
+ Timestamp(Nanosecond, Some("+00".into())),
Review Comment:
This unfortunately won't work. If you change the execution time to say +08
and try and run the query in [this
comment](https://github.com/apache/datafusion/issues/17993#issuecomment-3386013811)
you'll see it fails.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
