mbutrovich commented on code in PR #2447:
URL: https://github.com/apache/datafusion-comet/pull/2447#discussion_r2391075529


##########
common/src/main/scala/org/apache/comet/parquet/CometParquetUtils.scala:
##########
@@ -20,13 +20,30 @@
 package org.apache.comet.parquet
 
 import org.apache.hadoop.conf.Configuration
+import org.apache.parquet.crypto.DecryptionPropertiesFactory
+import org.apache.parquet.crypto.keytools.KeyToolkit
 import org.apache.spark.sql.internal.SQLConf
 
 object CometParquetUtils {
   private val PARQUET_FIELD_ID_WRITE_ENABLED = 
"spark.sql.parquet.fieldId.write.enabled"
   private val PARQUET_FIELD_ID_READ_ENABLED = 
"spark.sql.parquet.fieldId.read.enabled"
   private val IGNORE_MISSING_PARQUET_FIELD_ID = 
"spark.sql.parquet.fieldId.read.ignoreMissing"
 
+  // Map of unsupported encryption configuration key-value pairs
+  private val UNSUPPORTED_ENCRYPTION_CONFIGS: Map[String, Set[String]] = Map(
+    "parquet.encryption.algorithm" -> Set("AES_GCM_CTR_V1")

Review Comment:
   
https://github.com/apache/parquet-java/blob/f3542ee639fc4dbdcc79f82c0d30f202e8a2338a/parquet-hadoop/src/main/java/org/apache/parquet/crypto/keytools/PropertiesDrivenCryptoFactory.java#L60
   
   
https://github.com/apache/arrow-rs/blob/8eca76df2986908bcfa175fa6b16c52d1019a874/parquet/src/file/metadata/parser.rs#L494
   
   I can add links.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to