alamb commented on PR #17888:
URL: https://github.com/apache/datafusion/pull/17888#issuecomment-3361922832

   Many of the current failures are due because this used to work:
   
   ```sql
   select arrow_cast('2021-01-01T00:00:00', 'Timestamp(Nanosecond, 
Some("-05:00"))'
   ```
   
   or
   
   ```sql
   SELECT arrow_cast(secs, 'Timestamp(Millisecond, None)') FROM t
   ```
   
   After the arrow 57 upgrade it fails with errors like
   
   ```
   statement error DataFusion error: Execution error: Unsupported type 
'Timestamp\(Nanosecond, None\)'\. Must be a supported arrow type name such as 
'Int32' or 'Timestamp\(ns\)'\. Error expected double quoted string for 
Timezone, got 'None'
   ```
   
   ```sql
   # arrow_typeof_timestamp
   query T
   SELECT arrow_typeof(now()::timestamp)
   ----
   Timestamp(ns)
   ```
   
   I believe the problem is that the format of the timezone has changed into 
`Timestamp(ns)` and then the FromStr method doesn't handle that. I will work on 
filing an update
   
   I think what we need to do is support both formats for backwards 
compatibility. I will work on an upstream issue


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to