andygrove commented on code in PR #17871: URL: https://github.com/apache/datafusion/pull/17871#discussion_r2399341760
########## datafusion/spark/src/function/aggregate/avg.rs: ########## @@ -0,0 +1,337 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use std::{any::Any, sync::Arc}; +use arrow::array::{ + builder::PrimitiveBuilder, + cast::AsArray, + types::{Float64Type, Int64Type}, + Array, ArrayRef, ArrowNumericType, Int64Array, PrimitiveArray, +}; +use arrow::compute::sum; +use arrow::datatypes::{DataType, Field, FieldRef}; +use datafusion_common::{not_impl_err, Result, ScalarValue}; +use datafusion_expr::{ + type_coercion::aggregates::avg_return_type, Accumulator, AggregateUDFImpl, EmitTo, + GroupsAccumulator, ReversedUDAF, Signature}; +use arrow::array::ArrowNativeTypeOp; +use datafusion_expr::function::{AccumulatorArgs, StateFieldsArgs}; +use datafusion_expr::utils::format_state_name; +use datafusion_expr::Volatility::Immutable; +use DataType::*; + +/// AVG aggregate expression Review Comment: One difference is the use of i64 instead of u64 for the count. A future difference will be supporting ANSI mode. We haven't implemented that in Comet yet, but should be getting to this soon since it is important for supporting Spark 4, where ANSI mode is enabled by default. https://github.com/apache/datafusion-comet/issues/531 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
