aharpervc commented on code in PR #2041:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2041#discussion_r2382773376
##########
tests/sqlparser_common.rs:
##########
@@ -16533,6 +16537,40 @@ fn parse_create_procedure_with_parameter_modes() {
}
}
+#[test]
+fn create_procedure_with_parameter_default_value() {
Review Comment:
Hm, I don't understand. A parameter can be in/out and still have/not have a
default, right? Are you suggesting like
```diff
pub enum ArgMode {
In,
Out,
InOut,
+ InWithDefault(Expr),
+ OutWithDefault(Expr),
+ InOutWithDefault(Expr),
}
```
Perhaps I'm not understanding
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
